fix: Fix response handling error in bulk2.py#92
Open
dlouseiro wants to merge 1 commit intoMeltanoLabs:mainfrom
Open
fix: Fix response handling error in bulk2.py#92dlouseiro wants to merge 1 commit intoMeltanoLabs:mainfrom
bulk2.py#92dlouseiro wants to merge 1 commit intoMeltanoLabs:mainfrom
Conversation
dlouseiro
changed the title
bulk2.pybulk2.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves issue #91
Adjust code in line
bulk2.py:65not to convert response to adictusingresp.json()when at that point in the code therespobject has already been converted todictusing.jsonin linebulk2.py:58, causing the code to fail withAttributeError: 'dict' object has no attribute 'json'.