Skip to content

fix: URL-encode password value #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2024
+2 −1
Merged

fix: URL-encode password value #282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion target_snowflake/connector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from __future__ import annotations

import urllib.parse
from enum import Enum
from functools import cached_property
from operator import contains, eq
Expand Down Expand Up @@ -194,7 +195,7 @@ def get_sqlalchemy_url(self, config: dict) -> str:
if self.auth_method == SnowflakeAuthMethod.BROWSER:
params["authenticator"] = "externalbrowser"
elif self.auth_method == SnowflakeAuthMethod.PASSWORD:
params["password"] = config["password"]
params["password"] = urllib.parse.quote(config["password"])

for option in ["warehouse", "role"]:
if config.get(option):
Expand Down