feat: Support for Base64 String Private key #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
edgarrmondragon
changed the title
There was a problem hiding this comment.
Thanks @kronnk, this is a very comprehensive change!
Just some minor comments.
target_snowflake/connector.py
Outdated
| key_content = self.config["private_key"].encode() | ||
|
|
||
| private_key = self.config["private_key"] | ||
| self.logger.debug("Reading private key from config: %s", private_key) |
There was a problem hiding this comment.
Is there a risk that will leak the private key?
There was a problem hiding this comment.
Yeah, i should have removed that.
edgarrmondragon
approved these changes
Apr 3, 2025
|
Thanks! |
|
Something I missed: we should probably update the |
edgarrmondragon
added a commit
that referenced
this pull request
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant updates to the Meltano configuration and enhancements to the Snowflake connector. The changes improve configuration management and add new functionality for handling private keys.
Meltano Configuration Updates:
default_environmentandenvironmentsto specify deployment environments. (meltano.yml: meltano.ymlL3-R114)target-snowflakeloader settings to include new validation groups and reorganized settings for better readability. (meltano.yml: meltano.ymlL3-R114)Snowflake Connector Enhancements:
base64,binascii, andwarnto handle private key formats and deprecations. (target_snowflake/connector.py: target_snowflake/connector.pyR3-R10)SingerSDKDeprecationWarningto warn users about using private key pem formats. (target_snowflake/connector.py: target_snowflake/connector.pyR19)get_private_keymethod to support both PEM and base64 encoded private keys, with appropriate logging and error handling. (target_snowflake/connector.py: target_snowflake/connector.pyL131-R151)