Refactor into submodules #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this the `mypy_json_report` module was a single file. By using a `mypy_json_report` package we'll be able to split logic up into multiple files, and maintain the current namespace.
meshy
commented
Jan 3, 2024
Tenzer
reviewed
Jan 3, 2024
Member
Tenzer
left a comment
Tenzer
left a comment
There was a problem hiding this comment.
Looks good.
You should change the entrypoint for the package so it points at the new location for the main function:
mypy-json-report/pyproject.toml
Line 37 in 94a9aa0
"Nothing is something!"
This is consistent with the name of the class.
This will make working with these types easier, and better allows for future expansion.
Previously, we composed our parsing objects in the same function as we executed the parsing logic. This change separates those concerns, and will make splitting up this file easier.
These tests were only concerned with the parse command, so this name is more fitting.
While these are not (currently) explicitly used, it's nice to have them here for reference.
meshy
force-pushed
the
introduce-modules
branch
from
3ec3a5c to
0ef89af
Compare
Collaborator
Author
|
Thanks @Tenzer. I think I've addressed your points now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly just moving code around, but does add a "SUCCESS" return-code, and do a couple of renames.
I intend to add more commands (as a re-work of #18), and getting this out of the way will make that simpler.