-
Notifications
You must be signed in to change notification settings - Fork 4
DRAFT - Important rewrite of the module #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
this moduel stopped working in foundry version 12 and i dont think the original creator intends to update it. is it posible for you to claim the moduel and fix the issues? @p4535992 |
|
I took the maintance of the module, but never found the time to update the code for v12 the laste relase i amde is this https://github.com/p4535992/foundryvtt-comprehend-languages/releases/download/2.3.0/module.json |
seems the problem was that the actual module sends the api key in the request so anyone can use it... a proxy is the way to do. |
|
For anyone want to contribute to the project here the current registered fork of the project https://github.com/p4535992/foundryvtt-comprehend-languages |
I rewrote the module a little better with standards , but no matter how hard I tried I could not get myself to like (and compile) typescript, so I converted the project from typescript to javascript, then to meet the new system of Dnd5e I added a multisystem management of properties to translate the descriptions. Is the same method used by “Item Piles”.
Unfortunately the rewrite imposes a lot of stuff compared to the old logic... I would not want to create another module... if you want to try to take a look at my work if you want to make me a collaborator on the project , I don't mind fixing some bugs or additional features.