Skip to content

Allow bound functions and spending functions to take character values #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2025

Conversation

yihui
Copy link
Collaborator

@yihui yihui commented Mar 17, 2025

This will make it much easier to design the Shiny app.

@jdblischak
Copy link
Collaborator

xref: #408 (comment), #411, #413

@yihui
Copy link
Collaborator Author

yihui commented Mar 18, 2025

Yes, a nice side-effect of this PR is that we will be able to compare functions robustly. The character name will be resolved to function at run time, and compared to a target function that is also retrieved at run time. This avoids cases like saving gs_b with an older version of gsDesign2 and loading/comparing it against gs_b in a newer gsDesign2 version some months later.

I managed to delete a large object of 75 lines in the Shiny app after this PR.

@LittleBeannie I think this PR is ready to merge now. I'm not sure the jargons in the news entry are accurate. Please feel free to tweak the words if necessary.

@yihui yihui marked this pull request as ready for review March 18, 2025 17:16
Copy link
Collaborator

@LittleBeannie LittleBeannie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @yihui! This looks good to me!

@LittleBeannie LittleBeannie merged commit d33649d into Merck:main Mar 21, 2025
7 checks passed
@yihui yihui deleted the char-for-fun branch March 21, 2025 14:32
@yihui yihui mentioned this pull request Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants