Skip to content

Use magrittr pipe with text_summary() #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025

Conversation

jdblischak
Copy link
Collaborator

The new function text_summary() uses the native pipe (#526), which produces the following warning from R CMD build:

  NB: this package now depends on R (>= 4.1.0)
  WARNING: Added dependency on R >= 4.1.0 because package code uses the
  pipe |> or function shorthand \(...) syntax added in R 4.1.0.
  File(s) using such syntax:
    ‘text_summary.R’ ‘text_summary.Rd’

Currently our plan is to continue to support R >=3.5, so we need to use the magrittr pipe in the source code and examples (#517)

@jdblischak jdblischak self-assigned this May 1, 2025
Copy link
Collaborator

@nanxstats nanxstats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Once any of the Imports start to require R >= 4.1.0, we can bump it and switch to native pipes. So far all the Imports are all staying on >= 3.5 or so.

Copy link
Collaborator

@LittleBeannie LittleBeannie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jdblischak, for catching this. This is an area I need to pay closer attention to in order to avoid future occurrences!

@LittleBeannie LittleBeannie merged commit 153aca3 into Merck:main May 2, 2025
7 checks passed
@jdblischak jdblischak deleted the text-summary-pipe branch May 2, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants