Skip to content

Generalize info in the CP calculation under unequal randomization #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2025
Merged

Generalize info in the CP calculation under unequal randomization #546

merged 1 commit into from
May 19, 2025

Conversation

LittleBeannie
Copy link
Collaborator

@LittleBeannie LittleBeannie commented May 19, 2025 •
edited
Loading

To solve issue #545.

@LittleBeannie LittleBeannie added this to the 2025 Q2 milestone May 19, 2025
@LittleBeannie LittleBeannie self-assigned this May 19, 2025
@LittleBeannie LittleBeannie linked an issue May 19, 2025 that may be closed by this pull request
Generalize the info calculation under arbitrary randomization ratio #545
Closed
@LittleBeannie LittleBeannie requested review from yihui and keaven May 19, 2025 15:34
yihui
yihui approved these changes May 19, 2025
View reviewed changes
Copy link
Collaborator

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll defer the judgment to @keaven and update the app once the PR is merged.

@LittleBeannie LittleBeannie merged commit 320bb0e into main May 19, 2025
7 checks passed
@LittleBeannie LittleBeannie deleted the 545-generalize-the-info-calculation-under-arbitrary-randomization-ratio branch May 19, 2025 17:06
@yihui
Copy link
Collaborator

yihui commented May 20, 2025

I forgot to ask whether this sentence needs to be revised accordingly (since there's no longer event/4 in the code):

gsDesign2/vignettes/articles/story-cp.Rmd

Line 188 in 320bb0e

- The statistical information of future analysis is under the null hypothesis, i.e., event/4 for equal randomization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihui yihui yihui approved these changes

@keaven keaven Awaiting requested review from keaven

Assignees

@LittleBeannie LittleBeannie

Labels
High priority
Projects
None yet
Milestone
2025 Q2
Development

Successfully merging this pull request may close these issues.

Generalize the info calculation under arbitrary randomization ratio
2 participants
@LittleBeannie @yihui