Devr 3528 proper case race interactive baseline char tbl issue86 #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changed has been made in the interactive-baseline.Rmd. Thanks to review. |
wangben718
approved these changes
May 22, 2025
R/react_base_char.R
Outdated
| } | ||
|
|
||
| # 1) In data_population: extract the RACE values as a character vector | ||
| race_values_pop <- metadata_sl[["data_population"]]$RACE # Use $ to get a vector |
There was a problem hiding this comment.
Instead of revising the function, I would recommend to update the example to capitalize RACE variable in "vignettes/interactive-baseline.Rmd". The reason is that for other variable, it may also have the same demand to show value in upper or lower case. It is better to show the user a general solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated made in react_base_char.R file to address the RACE first letter capitalization request in issue #86. Thanks to review.