fix: bxl target patterns didn't accept multiple args#3
Merged
Conversation
I was surprised to learn that my code which the target exprs were used as a list no longer worked after a buck2 upgrade. These are documented as being a list, yet they were not actually parsed as such! https://buck2.build/docs/api/bxl/cli_args/#target_expr ``` def _collect_nix_deps(ctx): print(ctx.cli_args) pass main = bxl.main( impl = _collect_nix_deps, cli_args = { "target": bxl.cli_args.target_expr("Target(s) to build and import"), }, doc = """ Extracts the direct/buck2-transitive Nix dependency list of a buck2 target into a messy json file. """, ) ``` Before: ``` $ cargo r -p buck2 -- bxl test.bxl:main -- --target //:foo --target //:bar Compiling buck2_bxl v0.1.0 (/Users/jade/co/buck2/app/buck2_bxl) Compiling buck2 v0.1.0 (/Users/jade/co/buck2/app/buck2) Finished `dev` profile [optimized + debuginfo] target(s) in 5.84s Running `target/debug/buck2 bxl 'test.bxl:main' -- --target '//:foo' --target '//:bar'` buck2 daemon constraint mismatch: Version mismatch; killing daemon... Starting new buck2 daemon... Connected to new buck2 daemon. error: the argument '--target <target>' cannot be used multiple times ``` After: ``` Compiling buck2_bxl v0.1.0 (/Users/jade/co/buck2/app/buck2_bxl) Compiling buck2 v0.1.0 (/Users/jade/co/buck2/app/buck2) Finished `dev` profile [optimized + debuginfo] target(s) in 9.08s Running `target/debug/buck2 bxl 'test.bxl:main' -- --target '//:buck2' --target '//:buck2_bundle'` buck2 daemon constraint mismatch: Version mismatch; killing daemon... Starting new buck2 daemon... Connected to new buck2 daemon. struct(target=[gh_facebook_buck2//:buck2, gh_facebook_buck2//:buck2_bundle]) ``` I have no way to run the tests (facebook#1027), so you will have to forgive my attempt to add a test case here; try getting Claude to fix the bits I missed. The OSS build is down due to April Fools, so while I've tested this locally with some build fix hacks, I don't think the external CI will say much useful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was surprised to learn that my code which the target exprs were used as a list no longer worked after a buck2 upgrade.
These are documented as being a list, yet they were not actually parsed
as such! https://buck2.build/docs/api/bxl/cli_args/#target_expr
Before:
After:
I have no way to run the tests
(
facebook#1027), so you will have to
forgive my attempt to add a test case here; try getting Claude to fix
the bits I missed.
The OSS build is down due to April Fools, so while I've tested this
locally with some build fix hacks, I don't think the external CI will
say much useful.
Upstream PR: facebook#1279