Dynamic pool implementation and process separation per worker id #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tek
approved these changes
Oct 14, 2024
server/app/Server.hs
Outdated
Comment on lines
25
to
26
| open f = E.bracketOnError (socket AF_UNIX Stream 0) close $ \sock -> do | ||
| bind sock (SockAddrUnix f) |
There was a problem hiding this comment.
Suggested change
| open f = E.bracketOnError (socket AF_UNIX Stream 0) close $ \sock -> do | |
| bind sock (SockAddrUnix f) | |
| open = E.bracketOnError (socket AF_UNIX Stream 0) close $ \sock -> do | |
| bind sock (SockAddrUnix fp) |
😅
There was a problem hiding this comment.
oh I meant that you can use the top-level fp without passing it to open 😄
| hFlush stdout | ||
|
|
||
| getAssignableWorker :: IntMap (Bool, Maybe Id) -> Maybe Id -> Maybe (Int, (Bool, Maybe Id)) | ||
| getAssignableWorker workers mid' = List.find (isAssignable . snd) . IM.toAscList $ workers |
There was a problem hiding this comment.
FWIW, Foldable.find @IntMap searches in ascending key order 🙂
There was a problem hiding this comment.
Thanks. Unfortunately, in this case, we need to get Key (= Int) as well, so I couldn't use find directly on the map. toAscList was simply to fuse that key as element.
server/app/Pool.hs
Outdated
| writeTVar ref (pool {poolStatus = workers'}) | ||
|
|
||
| removeWorker :: TVar Pool -> Id -> IO () | ||
| removeWorker ref id' = do |
There was a problem hiding this comment.
maybe mask this function? not sure if these processes get cleaned up reliably on interrupt
There was a problem hiding this comment.
thanks for the suggestion. now wrapped it minimally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GHC compilation for different package modules needs to be separated to different GHC process for various reasons, such as safe dynamic linking / symbol finding and safe interface loading etc. So now each worker status is tagged with worker id and so jobs are distributed with the tag. Once done, the worker needs to be removed from the pool.
Therefore, this intrinsically introduces dynamic pool, spawning and terminating processes as demanded.
This PR implements such dynamic mechanism and worker-id based job distribution. Worker-id assignment per different haskell target is assumed from the build system rules.