buck-worker improvement and prepare for full integration #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wavewave
changed the title
wavewave
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes increase the granularity of the data stored in the shared cache, with slightly different update rules for
each of them. So far this has only been tested very superficially, so it will break in many nontrivial contexts.
To observe this mechanism a bit, this also adds a skeleton for recording some statistics about a compile job's
interactions with our shared cache, like how many of the BCO sets in the loader state at the end of the session have
been added freshly.
Otherwise, this includes a few tweaks to properly handle the Buck2 environment, like the CLI options
--bin-pathand--buck2-package-db, and environment variables included in RPC messages.