Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exfiltrate compilation artifacts #18

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Exfiltrate compilation artifacts #18

merged 4 commits into from
Jan 16, 2025

Conversation

tek
Copy link
Contributor

@tek tek commented Nov 25, 2024

  • Move pipeline creation into local code
  • Return ModIface and the bytecode Linkable instead of discarding the entire HomeModInfo
  • Extract ABI hash from that ModIface
  • Add an override for FinderCache that records some statistics

@tek tek requested a review from wavewave November 25, 2024 13:08
@tek tek marked this pull request as draft November 25, 2024 13:45
@tek tek force-pushed the tek/exfiltrate-artifacts branch from df3c937 to 78b29b0 Compare November 25, 2024 15:53
@tek tek marked this pull request as ready for review November 25, 2024 15:54
@tek tek force-pushed the tek/exfiltrate-artifacts branch 3 times, most recently from 094916b to ae863b5 Compare November 27, 2024 14:47
@tek tek force-pushed the tek/exfiltrate-artifacts branch from ae863b5 to d941465 Compare November 27, 2024 15:39
@tek tek force-pushed the tek/exfiltrate-artifacts branch 3 times, most recently from ae863b5 to a5e28f7 Compare January 16, 2025 13:30
wavewave
wavewave reviewed Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@wavewave wavewave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the main change is in Cache and compile pipeline, so it's desirable to have some comments on that. Otherwise, it looks good to me!

wavewave
wavewave approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@wavewave wavewave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the note with context!

@tek tek force-pushed the tek/exfiltrate-artifacts branch from 3a45169 to 1f799dd Compare January 16, 2025 18:11
tek added 4 commits January 16, 2025 19:13
@tek
make workers buildable with cabal
1b8f429
@tek
Exfiltrate compilation artifacts
524a8f8 
* Move pipeline creation into local code
* Return ModIface and the bytecode Linkable instead of discarding the entire HomeModInfo
* Extract ABI hash from that ModIface
* Add an override for FinderCache that records some statistics
@tek
add comments to clarify the purpose of pipelineOneshot and newFinderC…
dd5140e 
…ache
@tek
support --name=value style args for all buck options
88f79b7
@tek tek force-pushed the tek/exfiltrate-artifacts branch from 1f799dd to 88f79b7 Compare January 16, 2025 18:13
@tek tek merged commit 4201707 into main Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wavewave wavewave wavewave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tek @wavewave