Unify worker implementations #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wavewave
approved these changes
Jan 22, 2025
| @@ -464,11 +464,11 @@ moduleColumns m = | |||
| report :: | |||
| MonadIO m => | |||
| MVar Log -> | |||
| HscEnv -> | |||
| Maybe String -> | |||
There was a problem hiding this comment.
String is always subject to haddock comment. ;-)
| finalizeCache logVar hsc_env target artifacts cache0 = do | ||
| finalizeCache :: | ||
| MVar Log -> | ||
| Maybe String -> |
server/lib/Server.hs
Outdated
| @@ -49,8 +49,8 @@ runServer socketFile server = do | |||
| $ \(conn, _peer) -> void $ | |||
| forkFinally (server conn) (const $ gracefulClose conn 5000) | |||
|
|
|||
| initWorker :: FilePath -> [FilePath] -> WorkerId -> IO HandleSet | |||
| initWorker ghcPath dbPaths i = do | |||
| initWorker :: Bool -> FilePath -> [FilePath] -> WorkerId -> IO HandleSet | |||
There was a problem hiding this comment.
Bool is also subject to haddock comment.
especially thisimplCustom meaning is unclear from the name.
Introduce an optional second frontend plugin option that selects the implementation, either the default GHC main function or the local logic with custom session management.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce an optional second frontend plugin option that selects the implementation, either the default GHC main function or the local logic with custom session management.