Buck worker: Run only one GHC server and proxy requests from other workers #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wavewave
reviewed
Feb 6, 2025
buck-worker/Main.hs
Outdated
| @@ -1,4 +1,4 @@ | |||
| {-# language DataKinds, GADTs #-} | |||
| {-# language DataKinds, GADTs, MultiWayIf #-} | |||
There was a problem hiding this comment.
nit: let's use capital LANGUAGE here. :-)
wavewave
reviewed
Feb 6, 2025
buck-worker/Main.hs
Outdated
| MVar Cache -> | ||
| ServerRequest 'Normal ExecuteCommand ExecuteResponse -> | ||
| IO (ServerResponse 'Normal ExecuteResponse) | ||
| executeHandler cache (ServerNormalRequest _ ExecuteCommand {executeCommandArgv, executeCommandEnv}) = do | ||
| executeHandler status cache (ServerNormalRequest _ ExecuteCommand {executeCommandArgv, executeCommandEnv}) = do | ||
| when False do |
There was a problem hiding this comment.
This is better to be (1) removed if it is a temporary debug, (2) commented out with a note or (3) when debugMode and define debugMode = False somewhere at top level.
Just caught on my eyes. not necessary for this PR.
tek
force-pushed
the
tek/central-server
branch
2 times, most recently
from
7bb12c8 to
bcf453e
Compare
tek
force-pushed
the
tek/central-server
branch
from
bcf453e to
079c586
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
--singleis passed to the worker, it will use the GHC request handlers only in one worker process and proxy requests to the primary worker in the rest.Depends on #21