Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUX-1897]: more clear output for interpreting modules for eval #349

Conversation

lf-
Copy link
Contributor

@lf- lf- commented Feb 6, 2025

This output was confusing and adding another log line does make it clearer what it's doing even though it just takes a couple of seconds.

  • Labeled the PR with patch, minor, or major to request a version bump when it's merged.
  • Updated the user manual in docs/.
  • Added integration / regression tests in tests/.

Copy link

linear bot commented Feb 6, 2025

@github-actions github-actions bot added the patch Bug fixes or non-functional changes label Feb 6, 2025
9999years
9999years previously approved these changes Feb 6, 2025
@9999years
Copy link
Member

Thanks!!

@9999years
Copy link
Member

Oops, I guess some of the tests are keying on that log message

lf- and others added 2 commits March 7, 2025 17:25
This output was confusing and adding another log line does make it
clearer what it's doing even though it just takes a couple of seconds.
@9999years 9999years force-pushed the jadel/dux-1897-ghciwatch-tells-the-user-why-the-module-is-loading-again branch from 3215260 to 9275c17 Compare March 8, 2025 01:30
@lf- lf- merged commit 8502395 into main Mar 12, 2025
38 of 39 checks passed
@lf- lf- deleted the jadel/dux-1897-ghciwatch-tells-the-user-why-the-module-is-loading-again branch March 12, 2025 20:55
@lf-
Copy link
Contributor Author

lf- commented Mar 12, 2025

The CI check that was stuck is bogus, I checked it builds locally with nix build .#checks.aarch64-linux.ghciwatch-fmt.

Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Bug fixes or non-functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants