swift: add Codable implementation for sum-of-product types #77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support sum-of-product types in Swift by generating Codable implementations.
There are a couple of dimensions here, so I attempted to cover them all in tests:
In order to support "unknown" cases instead of throwing an error, the decoding logic needs to know the "unknown" field name at codegen time, so we are strongly nudged into making "unknown enum cases" a supported feature. This is done by adding
enumUnknownCase :: Maybe String
toOptions
and a correspondingenumEnumUnknownCase
toMoatEnum
. Only sum-of-product decoding takes this into account when decoding; the unknown case is generated for all enums as it doesn't hurt anything, but clients will have to implement their own Codable extensions to fall back to the unknown case for bare ("C-style") enums. We could implement that if desired, but I left that for a future improvement.