Generate moat list from haskell set #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephsumabat
commented
Feb 12, 2024
src/Moat/Class.hs
Outdated
| @@ -117,6 +118,9 @@ instance {-# OVERLAPPABLE #-} forall a. ToMoatType a => ToMoatType [a] where | |||
|
|
|||
| instance {-# OVERLAPPING #-} ToMoatType [Char] where toMoatType _ = Str | |||
|
|
|||
| instance forall a. ToMoatType a => ToMoatType (Set a) where | |||
| toMoatType _ = Array (toMoatType (Proxy @a)) | |||
There was a problem hiding this comment.
Maybe there's a more appropriate set type for ios and android that can be parsed from a json list? @kylebshr @tadfisher . I think it's fine to do this though imo since the json is a list.
There was a problem hiding this comment.
On Android it's just Set<A>, so the existing conversion works as is.
chiroptical
approved these changes
Feb 13, 2024
josephsumabat
force-pushed
the
joseph/moat-set-instance
branch
from
aafd4cd to
ac21c06
Compare
tadfisher
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aeson automatically converts Haskell sets to json lists. This performs the same conversion for moat allowing us to have records that are correct by construction in Haskell rather than converting to lists.