Fix css ssr generation bug - #22
Open
FoxMoss wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR patches bugged behavior in situations like the following:
2026-05-22.17-34-11.mp4
With this PR the bug is patched.
As I understand it the issues was with the SSR vdom not properly including the css id for all components. This traces back to an issue in src/core/jsx/index.ts where the element $ was set multiple times and on occasion with undefined values.
No idea where these undefined values come from.
Full disclosure here's the LLM outputs that I used: https://claude.ai/share/72dd5ce3-fdab-43e0-adff-4c6102d17d1c