Added Dockerfile for deployment#6
Open
GreenGru34n wants to merge 4 commits intoMercuryWorkshop:masterfrom
Open
Added Dockerfile for deployment#6GreenGru34n wants to merge 4 commits intoMercuryWorkshop:masterfrom
GreenGru34n wants to merge 4 commits intoMercuryWorkshop:masterfrom
Conversation
Author
|
My bad for small documentation, not all brains are made equally. |
Member
|
Looks fine but I personally cannot test it because I don't have Docker installed. I think you should be able to use a JSON config file when running the server though. |
Author
I am not entirely sure whether the JSON config file can be used when running the server; however, when I ran it, it did not work without the Dockerfile. I may, though, be mistaken |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Dockerfile I added, when ran, will successfully run and set up the wisp server.