Skip to content

test: reproduce mergify-engine architecture with chain file#17

Merged
mergify[bot] merged 1 commit intomainfrom
devs/jd/worktree-no-break-on-changes/I826764c9f2c8aeb5feaf247682c8ba9469d9b0f8
Mar 3, 2026
Merged

test: reproduce mergify-engine architecture with chain file#17
mergify[bot] merged 1 commit intomainfrom
devs/jd/worktree-no-break-on-changes/I826764c9f2c8aeb5feaf247682c8ba9469d9b0f8

Conversation

@jd
Copy link
Member

@jd jd commented Mar 3, 2026

Add test_mergify_engine_architecture that recreates the three-tier
migration layout (static chain + dynamic chain + hybrid) at a smaller
scale, generates the chain file via generate_chain_file, and verifies
both the JSON contents and the full linear walk from root to head.

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com

Copilot AI review requested due to automatic review settings March 3, 2026 17:16
@jd
Copy link
Member Author

jd commented Mar 3, 2026

This pull request is part of a stack:

  1. test: reproduce mergify-engine architecture with chain file (#17) 👈

@mergify mergify bot had a problem deploying to Mergify Merge Protections March 3, 2026 17:16 Failure
@mergify
Copy link

mergify bot commented Mar 3, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 🤖 Continuous Integration

Wonderful, this rule succeeded.
  • all of:
    • check-success=all-greens

🟢 👀 Review Requirements

Wonderful, this rule succeeded.
  • any of:
    • #approved-reviews-by>=1
    • author = dependabot[bot]
    • author = mergify-ci-bot

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

🟢 📕 PR description

Wonderful, this rule succeeded.
  • body ~= (?ms:.{48,})

@mergify mergify bot requested a review from a team March 3, 2026 17:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new regression test that mirrors the “static chain + dynamic chain + hybrid” Alembic migration architecture (as seen in mergify-engine) to validate generate_chain_file output and ensure the complete revision history forms a single linear chain from root to head.

Changes:

  • Add test_mergify_engine_architecture to construct a miniature three-tier migration layout (static + dynamic + hybrid).
  • Verify the generated revision_chain.json contains only dynamic migrations and correctly chains a post-hybrid dynamic migration after the hybrid.
  • Reconstruct the full chain (static + hybrid from files, dynamic from JSON) and assert the exact root→head walk order.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jd jd force-pushed the devs/jd/worktree-no-break-on-changes/I826764c9f2c8aeb5feaf247682c8ba9469d9b0f8 branch from bcaf42e to cdc0629 Compare March 3, 2026 17:28
@mergify mergify bot deployed to Mergify Merge Protections March 3, 2026 17:28 Active
sileht
sileht previously approved these changes Mar 3, 2026
Base automatically changed from devs/jd/worktree-no-break-on-changes/I628e316231cf513864b3565bcc347b2debecd2ea to main March 3, 2026 17:31
@mergify
Copy link

mergify bot commented Mar 3, 2026

@jd this pull request is now in conflict 😩

@mergify mergify bot added the conflict label Mar 3, 2026
Add test_mergify_engine_architecture that recreates the three-tier
migration layout (static chain + dynamic chain + hybrid) at a smaller
scale, generates the chain file via generate_chain_file, and verifies
both the JSON contents and the full linear walk from root to head.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Change-Id: I826764c9f2c8aeb5feaf247682c8ba9469d9b0f8
Claude-Session-Id: f2902019-6258-4c62-9887-f23b8128665f
@jd jd force-pushed the devs/jd/worktree-no-break-on-changes/I826764c9f2c8aeb5feaf247682c8ba9469d9b0f8 branch from cdc0629 to 995279d Compare March 3, 2026 17:36
@mergify mergify bot removed the conflict label Mar 3, 2026
@mergify mergify bot dismissed sileht’s stale review March 3, 2026 17:36

Pull request has been modified.

@mergify mergify bot deployed to Mergify Merge Protections March 3, 2026 17:36 Active
@mergify mergify bot requested a review from a team March 3, 2026 17:36
@mergify mergify bot merged commit 2b8c0d6 into main Mar 3, 2026
14 checks passed
@mergify mergify bot deleted the devs/jd/worktree-no-break-on-changes/I826764c9f2c8aeb5feaf247682c8ba9469d9b0f8 branch March 3, 2026 17:43
@mergify
Copy link

mergify bot commented Mar 3, 2026

Merge Queue Status

Rule: default


  • Entered queue2026-03-03 17:43 UTC
  • Checks passed · in-place
  • Merged2026-03-03 17:43 UTC · at 995279df727d02648881070d98cd9f3dce641a1d

This pull request spent 7 seconds in the queue, with no time running CI.

Required conditions to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants