Conversation
Thanks to the fact that the latest semantics of CCV (and therefore the tweak_embed_data helper) tweaking by a zero-length buffer is a no-operation on the public key, there is no longer the need to distinguish between 'augmented' and 'not augmented' contracts: all contracts can be assumed as containing some data, and for contracts that do nothing with that data, then the data is identically empty. This allows simplifying several parts of the codebase, and removing case-base decisions in the ContractManager.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to the fact that the latest semantics of CCV (and therefore the
tweak_embed_datahelper) tweaking by a zero-length buffer is a no-operation on the public key, there is no longer the need to distinguish between 'augmented' and 'not augmented' contracts: all contracts can be assumed as containing some data, and for contracts that do nothing with that data, then the data is identically empty.This allows simplifying several parts of the codebase, and removing case-base decisions in the ContractManager.