PHP formatting improvements#414
Open
jeffski wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
I think the request body would be better written as: However when I use In any case, the improvements I have made are better than the current template so they should be merged as a first step. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a couple issues, 1 bug and 1 improvement related to the PHP code examples.
When generating documentation, the PHP code example is cut off at the start and in my case looks like this (won't work):
With this update it will look like (correct):
I think the
<?phptag at the start is breaking things, but I think any PHP developer is smart enough to know to add the tag in to their script so it isn't needed.Also you can see that the code now uses modern array syntax
[], available since PHP7, released in 2015. I think support for PHP5 which is EOL can be dropped in favour of the[]syntax.