fix(sdk): handle relative URLs in #handleAuthorizationResponse()
#5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying out Mermaid-Chart/vscode-mermaid-chart#6 and was getting an error like
URL
is not valid, due to missing abaseUrl
onplugins/packages/sdk/src/index.ts
Lines 103 to 104 in 0ff60d5
Since we never actually need the hostname for this URL, I've just given it a dummy baseURL, like
plugins/packages/sdk/src/index.ts
Line 109 in da361b5
While implementing this, I also added some tests and basic CI to sanity check that this code actually worked!