-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: managed agents follow-ups - safety, protocol consistency, CLI parity #1440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
0e86e3b
feat: managed agents follow-ups - safety, protocol consistency, CLI p…
praisonai-triage-agent[bot] d091c16
fix: tighten managed local package install safety and restore session…
Copilot e9b2ef9
test: cover async loop install path and clarify loop detection
Copilot ff1c542
fix: address final reviewer feedback
praisonai-triage-agent[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor:
SessionInfopath and fallback return subtly different dicts.When
sess.statusisNone,SessionInfo.to_dict()omits thestatuskey entirely (seeprotocols.pylines 112–113), but theexcept ImportErrorfallback at lines 594–597 always emits"status": None. Any consumer usingresult["status"]vsresult.get("status")will behave differently depending on which path runs. Given the fallback is dead code in practice (SessionInfolives in the same core SDK package as this caller), consider dropping the try/except and just usingSessionInfounconditionally, or align the fallback to also omit keys whenNone.♻️ Simpler version without fallback
📝 Committable suggestion
🤖 Prompt for AI Agents