fix: Resolve Ollama infinite tool call loops by improving response handling

src/praisonai-agents/praisonaiagents/llm/llm.py

@@ -302,6 +302,42 @@ def _is_ollama_provider(self) -> bool:
 
         return False
 
+    def _generate_ollama_tool_summary(self, tool_results: List[Any], response_text: str) -> Optional[str]:
+        """
+        Generate a summary from tool results for Ollama to prevent infinite loops.
+
+        This prevents infinite loops where Ollama provides an empty response after a
+        tool call, expecting the user to prompt for a summary.
+
+        Args:
+            tool_results: The list of results from tool execution.
+            response_text: The text response from the LLM.
+
+        Returns:
+            A summary string if conditions are met, otherwise None.
+        """
+        # Constant for minimal response length check
+        OLLAMA_MIN_RESPONSE_LENGTH = 10
+
+        # Only generate summary for Ollama with tool results
+        if not (self._is_ollama_provider() and tool_results):
+            return None
+
+        # If response is substantial, no summary needed
+        if response_text and len(response_text.strip()) > OLLAMA_MIN_RESPONSE_LENGTH:
+            return None
+
+        # Build tool summary efficiently
+        summary_lines = ["Based on the tool execution results:"]
+        for i, result in enumerate(tool_results):
+            if isinstance(result, dict) and 'result' in result:
+                function_name = result.get('function_name', 'Tool')
+                summary_lines.append(f"- {function_name}: {result['result']}")
+            else:
+                summary_lines.append(f"- Tool {i+1}: {result}")
+
+        return "\n".join(summary_lines)
+
     def _format_ollama_tool_result_message(self, function_name: str, tool_result: Any) -> Dict[str, str]:
         """
         Format tool result message for Ollama provider.
@@ -1072,6 +1108,12 @@ def get_response(
                             final_response_text = response_text.strip()
                             break
 
+                        # Special handling for Ollama to prevent infinite loops
+                        tool_summary = self._generate_ollama_tool_summary(tool_results, response_text)
+                        if tool_summary:
+                            final_response_text = tool_summary
+                            break
+
                         # Otherwise, continue the loop to check if more tools are needed
                         iteration_count += 1
                         continue
@@ -1815,6 +1857,12 @@ async def get_response_async(
                         final_response_text = response_text.strip()
                         break
 
+                    # Special handling for Ollama to prevent infinite loops
+                    tool_summary = self._generate_ollama_tool_summary(tool_results, response_text)
+                    if tool_summary:
+                        final_response_text = tool_summary
+                        break
+
                     # Continue the loop to check if more tools are needed
                     iteration_count += 1
                     continue

test_ollama_fix.py

@@ -0,0 +1,185 @@
+#!/usr/bin/env python3
+"""
+Test script to validate the Ollama infinite loop fix.
+
+This script tests that:
+1. Ollama provider detection works correctly
+2. Tool results summary generation works as expected
+3. Loop termination logic prevents infinite loops
+4. Backward compatibility is maintained for other providers
+"""
+
+import sys
+import os
+
+# Add the source directory to the path
+sys.path.insert(0, os.path.join(os.path.dirname(__file__), 'src', 'praisonai-agents'))
+
+def test_module_imports():
+    """Test that we can import the required modules."""
+    try:
+        from praisonaiagents.llm.llm import LLM
+        print("✅ Successfully imported LLM module")
+        return True
+    except ImportError as e:
+        print(f"❌ Failed to import LLM module: {e}")
+        return False
+
+def test_ollama_provider_detection():
+    """Test Ollama provider detection logic."""
+    try:
+        from praisonaiagents.llm.llm import LLM
+
+        # Test Ollama provider detection
+        ollama_llm = LLM(model="ollama/qwen3")
+        is_ollama = ollama_llm._is_ollama_provider()
+
+        if is_ollama:
+            print("✅ Ollama provider detection works correctly")
+        else:
+            print("❌ Ollama provider detection failed")
+            return False
+
+        # Test non-Ollama provider
+        openai_llm = LLM(model="gpt-4o-mini")
+        is_not_ollama = not openai_llm._is_ollama_provider()
+
+        if is_not_ollama:
+            print("✅ Non-Ollama provider detection works correctly")
+        else:
+            print("❌ Non-Ollama provider incorrectly detected as Ollama")
+            return False
+
+        return True
+
+    except Exception as e:
+        print(f"❌ Provider detection test failed: {e}")
+        return False
+
+def test_tool_summary_generation():
+    """Test that tool results summary generation works correctly by calling production code."""
+    try:
+        from praisonaiagents.llm.llm import LLM
+
+        # Create an Ollama LLM instance
+        ollama_llm = LLM(model="ollama/test")
+
+        # Mock tool results like what would be generated
+        tool_results = [
+            "The stock price of Google is 100", 
+            200
+        ]
+
+        # Test with empty response (should generate summary)
+        summary = ollama_llm._generate_ollama_tool_summary(tool_results, "")
+        expected_summary = "Based on the tool execution results:\n- Tool 1: The stock price of Google is 100\n- Tool 2: 200"
+
+        if summary == expected_summary:
+            print("✅ Tool summary generation (empty response) works correctly")
+        else:
+            print("❌ Tool summary generation (empty response) failed")
+            print(f"Expected: {repr(expected_summary)}")
+            print(f"Got: {repr(summary)}")
+            return False
+
+        # Test with minimal response (should generate summary)
+        summary_minimal = ollama_llm._generate_ollama_tool_summary(tool_results, "ok")
+        if summary_minimal == expected_summary:
+            print("✅ Tool summary generation (minimal response) works correctly")
+        else:
+            print("❌ Tool summary generation (minimal response) failed")
+            return False
+
+        # Test with substantial response (should NOT generate summary)
+        summary_substantial = ollama_llm._generate_ollama_tool_summary(tool_results, "This is a detailed response with more than 10 characters")
+        if summary_substantial is None:
+            print("✅ Tool summary generation correctly skips substantial responses")
+        else:
+            print("❌ Tool summary generation incorrectly generated summary for substantial response")
+            return False
+
+        # Test with non-Ollama model (should NOT generate summary)
+        non_ollama_llm = LLM(model="gpt-4o-mini")
+        summary_non_ollama = non_ollama_llm._generate_ollama_tool_summary(tool_results, "")
+        if summary_non_ollama is None:
+            print("✅ Tool summary generation correctly skips non-Ollama models")
+        else:
+            print("❌ Tool summary generation incorrectly generated summary for non-Ollama model")
+            return False
+
+        return True
+
+    except Exception as e:
+        print(f"❌ Tool summary generation test failed: {e}")
+        return False
+
+def test_backward_compatibility():
+    """Test that the fix doesn't break other LLM providers."""
+    try:
+        from praisonaiagents.llm.llm import LLM
+
+        # Test that non-Ollama providers aren't affected
+        models_to_test = [
+            "gpt-4o-mini",
+            "claude-3-sonnet",
+            "gemini/gemini-2.5-pro"
+        ]
+
+        for model in models_to_test:
+            try:
+                llm = LLM(model=model)
+                is_ollama = llm._is_ollama_provider()
+                if not is_ollama:
+                    print(f"✅ Model {model} correctly identified as non-Ollama")
+                else:
+                    print(f"❌ Model {model} incorrectly identified as Ollama")
+                    return False
+            except Exception as e:
+                print(f"⚠️  Could not test model {model}: {e}")
+
+        print("✅ Backward compatibility verified")
+        return True
+
+    except Exception as e:
+        print(f"❌ Backward compatibility test failed: {e}")
+        return False
+
+def main():
+    """Run all tests."""
+    print("🚀 Testing Ollama infinite loop fix...")
+    print("=" * 50)
+
+    tests = [
+        ("Module Imports", test_module_imports),
+        ("Ollama Provider Detection", test_ollama_provider_detection),
+        ("Tool Summary Generation", test_tool_summary_generation),
+        ("Backward Compatibility", test_backward_compatibility),
+    ]
+
+    passed = 0
+    total = len(tests)
+
+    for test_name, test_func in tests:
+        print(f"\n🧪 Running: {test_name}")
+        try:
+            if test_func():
+                passed += 1
+                print(f"✅ {test_name}: PASSED")
+            else:
+                print(f"❌ {test_name}: FAILED")
+        except Exception as e:
+            print(f"❌ {test_name}: ERROR - {e}")
+
+    print("\n" + "=" * 50)
+    print(f"📊 Test Results: {passed}/{total} tests passed")
+
+    if passed == total:
+        print("🎉 All tests passed! The Ollama fix is working correctly.")
+        return True
+    else:
+        print("⚠️  Some tests failed. Please review the implementation.")
+        return False
+
+if __name__ == "__main__":
+    success = main()
+    sys.exit(0 if success else 1)