docs: update custom-memory-adapters.mdx for friendly imports + add_/has_ aliases#805
Conversation
…as_ aliases (fixes #803)
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
There was a problem hiding this comment.
Code Review
This pull request updates the documentation and lazy imports in praisonaiagents/__init__.py to support the new memory adapter registry API, introducing canonical names like add_memory_adapter and add_memory_factory. The review feedback suggests importing these new functions from praisonaiagents.memory.adapters instead of praisonaiagents.memory.adapters.registry to maintain consistency with other memory-related registry functions.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| 'add_memory_adapter': ('praisonaiagents.memory.adapters.registry', 'add_memory_adapter'), | ||
| 'add_memory_factory': ('praisonaiagents.memory.adapters.registry', 'add_memory_factory'), |
There was a problem hiding this comment.
For consistency with other memory adapter registry functions (such as register_memory_adapter, register_memory_factory, get_memory_adapter, list_memory_adapters, and has_memory_adapter), add_memory_adapter and add_memory_factory should be imported from praisonaiagents.memory.adapters instead of directly from praisonaiagents.memory.adapters.registry.
| 'add_memory_adapter': ('praisonaiagents.memory.adapters.registry', 'add_memory_adapter'), | |
| 'add_memory_factory': ('praisonaiagents.memory.adapters.registry', 'add_memory_factory'), | |
| 'add_memory_adapter': ('praisonaiagents.memory.adapters', 'add_memory_adapter'), | |
| 'add_memory_factory': ('praisonaiagents.memory.adapters', 'add_memory_factory'), |
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
Caution Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted. Error details |
Summary
Sanity check results (both printed ok)
python -c from praisonaiagents import register_memory_adapter, register_memory_factory, get_memory_adapter, list_memory_adapters ok
python -c from praisonaiagents import add_memory_adapter, add_memory_factory, has_memory_adapter ok
Fixes #803
Generated with Claude Code https://claude.ai/code