Don't check for duplicate haplosome IDs - #554
Merged
Merged
Conversation
bhaller
reviewed
Sep 7, 2025
| // due to the nature of the values being inserted. Shouldn't be a big deal in the grand scheme of things. | ||
| // Previously, we checked for duplicate pedigree IDs here as well, just in case. | ||
| // __CreateSubpopulationsFromTabulation() does this for haplosome IDs in | ||
| // living individuals already pedigree IDs; however, it was found to be |
Contributor
There was a problem hiding this comment.
the comment text here is garbled and I'm not sure what it is intended to say; please fix
petrelharp
force-pushed
the
no_dup_id_check
branch
from
September 7, 2025 22:31
eef9e92 to
7d0a5f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #538, the check that no haplosome IDs overlap is being overly restrictive for applciations involving parallel simulations. This moves that duplicate haplosome ID check to "only haplosomes in individuals", not all of them.