Explicitly check for existence of cset-dev environment when running development CSET#1524
Merged
Merged
Conversation
When cset would fail, it exited non-zero which then triggered the else branch, causing an attempt to run with no environment. This would always also fail, so it preserved the workflow behaviour, but it produced some messy and confusing logs.
James Frost (jfrost-mo)
added
bug
James Frost (jfrost-mo)
changed the title
Contributor
|
|
David Flack (daflack)
approved these changes
Jul 23, 2025
David Flack (daflack)
left a comment
David Flack (daflack)
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When cset would fail, it exited non-zero which then triggered the else branch, causing an attempt to run with no environment. This would always also fail, so it preserved the workflow behaviour, but it produced some messy and confusing logs.
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.