Stop writing overly verbose logs#1525
Merged
Merged
Conversation
This statement could easily produce several thousand uninteresting lines, which make it harder to find that actually useful bits of the logs.
These are far too low-level to be full info level messages. The else cases are also removed, as they produce several hundred lines of boring output, and can be inferred from the lack of a positive message.
James Frost (jfrost-mo)
requested a review
from Sylvia Bohnenstengel (Sylviabohnenstengel)
James Frost (jfrost-mo)
added
small
James Frost (jfrost-mo)
changed the title
Sylvia Bohnenstengel (Sylviabohnenstengel)
approved these changes
Jul 22, 2025
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of our log messages are far too verbose, adding thousands of lines of logs of very little value. This prevents being able to view the full logs in the cylc gui, and makes them harder to navigate otherwise.
This PR removes the worst couple offenders.
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.