Adds diagnostics to identify properties of the MAUL#2058
Open
David Flack (daflack) wants to merge 43 commits into
Open
Adds diagnostics to identify properties of the MAUL#2058David Flack (daflack) wants to merge 43 commits into
David Flack (daflack) wants to merge 43 commits into
Conversation
Contributor
|
|
David Flack (daflack)
force-pushed
the
1960_presence_of_mauls
branch
from
2c1eab0 to
9b7c885
Compare
David Flack (daflack)
force-pushed
the
1961_MAUL_properties_properties_of_the_MAUL
branch
from
096ef3b to
a63db5f
Compare
David Flack (daflack)
force-pushed
the
1960_presence_of_mauls
branch
from
9b7c885 to
0e2f578
Compare
David Flack (daflack)
force-pushed
the
1961_MAUL_properties_properties_of_the_MAUL
branch
from
40e6ec7 to
6ee91d0
Compare
Collaborator
Author
|
Focusing on an initial implementation, will correct handling of x and y coordinates, and coordinate order as part of optimization which will be a separate issue (#2114)- will work on global model data though. |
David Flack (daflack)
requested review from
Sylvia Bohnenstengel (Sylviabohnenstengel),
James Frost (jfrost-mo) and
James Warner (jwarner8)
and removed request for
James Frost (jfrost-mo)
Member
|
David Flack (@daflack) added further comments directly to precipitation.py to help understanding for non expert readers. Also added further tests directly to test_precipitation.py. Normally these show up as suggestion when done during teh code review so not entirely sure why they do not show (on my side) as suggestions, but as commits. |
Sylvia Bohnenstengel (Sylviabohnenstengel)
requested changes
May 12, 2026
Member
Sylvia Bohnenstengel (Sylviabohnenstengel)
left a comment
Sylvia Bohnenstengel (Sylviabohnenstengel)
left a comment
There was a problem hiding this comment.
happy to approve once suggested changes are accepted/rejected.
David Flack (daflack)
requested a review
from Sylvia Bohnenstengel (Sylviabohnenstengel)
David Flack (daflack)
force-pushed
the
1960_presence_of_mauls
branch
from
a7351e4 to
237b977
Compare
This operator is not optimized as is in place to test that it works prior to optimization.
Adding more context to help users understand this complex loop.
add more explanation to the code
adding comments to different case block for future clarity
adding further comment for future undestanding explaining dimension cases.
expanding comment for further clarity
David Flack (daflack)
force-pushed
the
1961_MAUL_properties_properties_of_the_MAUL
branch
from
5194d59 to
69c88e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1961
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.
rose-suite.conf.examplehas been updated if new diagnostic added.