Skip to content

Aux coord aggregation fix#2081

Open
mo-tomosevans wants to merge 7 commits into
mainfrom
time_coord_aggregation_fix
Open

Aux coord aggregation fix#2081
mo-tomosevans wants to merge 7 commits into
mainfrom
time_coord_aggregation_fix

Conversation

@mo-tomosevans
Copy link
Copy Markdown

@mo-tomosevans mo-tomosevans commented Apr 24, 2026

Proposed solution to address #2023.

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Ensure rose-suite.conf.example has been updated if new diagnostic added.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@mo-tomosevans mo-tomosevans self-assigned this Apr 24, 2026
@mo-tomosevans
Copy link
Copy Markdown
Author

The changes here apply the method used in the UK Trialling version of the RES toolbox for data which does not have time in a dimension coordinate but need aggregating.

I've created new functions to enable this, and have also included an argument for ensure_aggregatable_across_cases which is then able to proceed with aggregating cubes as long as they have time coordinates as either DimCoords or AuxCoords.
Happy to discuss a better option than including an argument in this function if there's a preferred method.

Running these changes generated aggregated plots for ukv and mogrepsuk data.

@github-actions
Copy link
Copy Markdown
Contributor

Coverage

@mo-tomosevans
Copy link
Copy Markdown
Author

Need to add tests for changes in aggregate and _utils operator scripts to increase coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Built-in aggregation recipes do not work for operational UKV/MORGEPSUK data form MASS

1 participant