Improve ODB2 format support#2115
Draft
Scott Wales (ScottWales) wants to merge 12 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor ODB2 support
Fixes #2102
metplus_prep_obsopt fileodb2will read ODB2 files from an arbitrary directory set using$CUSTOM_ODB_PATTERN. This pattern can use strftime placeholders and wildcard globs, and will automatically decompress the files if it detects a matching extension.PrepODB2is an interface for sites to fill in their own ODB2 directory patterns, see the example for BOM data at NCI inodb2/bom.py. BOM data on internal systems will use this interface as well in a restricted repo.Z0instead ofP0, so they get picked up by verpy correctlyAt NCI-Gadi site observations can now be sourced from either a BOM operational system with
or from ODB2 files on disk with
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.
rose-suite.conf.examplehas been updated if new diagnostic added.