Skip to content

Fix single point ts#2118

Open
refszkentla wants to merge 3 commits into
mainfrom
fix_single_point_ts
Open

Fix single point ts#2118
refszkentla wants to merge 3 commits into
mainfrom
fix_single_point_ts

Conversation

@refszkentla
Copy link
Copy Markdown
Contributor

@refszkentla refszkentla commented May 12, 2026

fixes #1498; also fixes IndexError exceptions when an aggregation switch is absent in Config. (Config handles missing switch with its getattr() but if the switch is missing - e.g. in the case of no aggregation ordered - trying to access the switch list item raises IndexError)

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Ensure rose-suite.conf.example has been updated if new diagnostic added.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@refszkentla refszkentla added bug Something isn't working small Small issue that should be quick to resolve labels May 12, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Coverage

@refszkentla
Copy link
Copy Markdown
Contributor Author

refszkentla commented May 12, 2026

I did not find any particular tests for loaders, so did not change/add any tests.
This is not a new feature, so I have not filled any doc.
Once I have implemented the single aggregation IndexError fix, I asked AI model to populate across other aggregation loops in submodules in loaders/ folder ;). I do not know what is the intended way to attribute it.

@refszkentla
Copy link
Copy Markdown
Contributor Author

one more thing. Actually, I am not quite sure why the single point recipe needs SUBAREA_ variables, i guess it could be safely removed. But, since I am not sure, i kept it.

@daflack
Copy link
Copy Markdown
Collaborator

Thanks for raising this PR. I'm hoping to get around to review it on Thursday. To answer your question around attributing AI, all we require is that if AI has been used it is mention in the PR. So I can confirm that you have attributed it in the intended way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working small Small issue that should be quick to resolve

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Single point time series not running when enabled

3 participants