Adds saturation fraction#2149
Conversation
|
|
David Flack (daflack)
requested review from
James Frost (jfrost-mo) and
James Warner (jwarner8)
David Flack (daflack)
requested review from
Sylvia Bohnenstengel (Sylviabohnenstengel) and
ukmo-huw-lewis
James Warner (jwarner8)
left a comment
James Warner (jwarner8)
left a comment
There was a problem hiding this comment.
Looks good, a few small queries/clarifications.
| ) | ||
| # Determine array information of input cube to get | ||
| # correct cube to copy across to. | ||
| if len(w.coord("realization").points) != 1 and len(w.coord("time").points) != 1: |
There was a problem hiding this comment.
are we making assumptions of the cube structure/how dimensions are ordered?
There was a problem hiding this comment.
I think there is some code somewhere in CSET which returns the axis names and which index they are. It might be in one of Huw's merged branches. If we do assume a structure, be good to be clear about this in code in comments so easier to debug later on
There was a problem hiding this comment.
Currently we are assuming a structure, will add to documentation/notes and log it. Will be updated along with the other MAUL diagnostics in #2114. Priority is to get a fundamentally working version in and optimisations come at a later point.
|
|
||
| It can be calculated as | ||
|
|
||
| .. math:: spw = frac{1}{\rho_w} \int \frac{w}{RH} dz |
There was a problem hiding this comment.
any ref/book citation we can use to ground this?
precipitable water
Co-authored-by: James Warner <62252918+jwarner8@users.noreply.github.com>
Co-authored-by: James Warner <62252918+jwarner8@users.noreply.github.com>
David Flack (daflack)
force-pushed
the
1965_saturation_fraction
branch
from
a2bcddb to
fa5af11
Compare
2 participants
Also includes operators for precipitable water and saturation precipitable water as needed within saturation fraction code.
Fixes #1965
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.
rose-suite.conf.examplehas been updated if new diagnostic added.