Refactor wet model drivers and controllers#55
Draft
Pierre Siddall (Pierre-siddall) wants to merge 22 commits into
Draft
Refactor wet model drivers and controllers#55Pierre Siddall (Pierre-siddall) wants to merge 22 commits into
Pierre Siddall (Pierre-siddall) wants to merge 22 commits into
Conversation
Co-authored-by: harry-shepherd <17930806+harry-shepherd@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Code Reviewer:
This PR migrates over the ticket number 523 from subversion which was authored by Harry Shepherd (@harry-shepherd) and contained the following description:
As part of the first priority items for the drivers refactor, there is extensive work to do on the wet model drivers and controllers. For this context I take these to be:
As all of these have similar functionality, and areas of code that work in the same way. The original design brief for the drivers was to ensure orthogonality between components, and this will still be followed to allow the SI^3^ controller to easily be reconfigured into a driver if that is desired. However code reuse will be made use of as much as possible (which was not the case in the original implementation of the controllers).
As CICE is not part of GC5, refactoring of that driver is a 2nd tier priority item.
Work in this ticket includes (but is not limited to):
NEMO
SI^3 and Top
The controllers will be removed
closes #60
Code Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
readability of the code
Testing
acceptable (eg. kgo changes)
tests, unit tests, etc.)
Security Considerations
Performance Impact
performance measurements have been conducted
AI Assistance and Attribution
of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
Simulation Systems AI policy
(including attribution labels)
Documentation
confirmed that it builds correctly
Code Review