add oneInch v6 swap api #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xelMag0
reviewed
Nov 2, 2024
| "cors": "^2.8.5", | ||
| "dotenv": "^16.0.0", | ||
| "express": "^4.18.1", | ||
| "express": "^4.21.1", |
There was a problem hiding this comment.
was it needed to update the dependencies ?
| return new Ok( | ||
| const quoteData: OneInchQuoteResponse = r.data; | ||
|
|
||
| // logger.debug('OneInch quote response', r.data); |
There was a problem hiding this comment.
remove unnecessary comments
| chainId, | ||
| ); | ||
|
|
||
| // logger.debug('normalizedResponse', normalizedResponse); |
There was a problem hiding this comment.
remove unncessary comments
| ); | ||
| sellTokenAmount, | ||
| ); | ||
| // logger.debug('normalizedResponse', normalizedResponse); |
There was a problem hiding this comment.
remove unncessary comments
| ); | ||
|
|
||
| return new Ok( | ||
| // logger.debug(`OneInch swap response ${JSON.stringify(r.data)}`); |
There was a problem hiding this comment.
remove unncessary comments
| '0x111111125421ca6dc452d289314280a0f8842a65', | ||
| [SupportedChainId.OPTIMISM]: '0x111111125421ca6dc452d289314280a0f8842a65', | ||
| [SupportedChainId.MAINNET]: '0x111111125421ca6dc452d289314280a0f8842a65', | ||
| [SupportedChainId.BASE]: '0x111111125421ca6dc452d289314280a0f8842a65', |
There was a problem hiding this comment.
do their contract have the same address on all chains ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.