Skip to content

refactor: migrate to @metamask/messenger#383

Merged
mikesposito merged 5 commits into
mainfrom
mikesposito/messenger
Oct 27, 2025
Merged

refactor: migrate to @metamask/messenger#383
mikesposito merged 5 commits into
mainfrom
mikesposito/messenger

Conversation

@mikesposito

@mikesposito mikesposito commented Sep 29, 2025

Copy link
Copy Markdown
Member

Migrate from RestrictedMessenger to @metamask/messenger.


Note

Migrates messenger types and test setup from RestrictedMessenger to @metamask/messenger across keyring packages, updating dependencies and changelogs.

  • Messaging migration (BREAKING):
    • Replace RestrictedMessenger from @metamask/base-controller with new Messenger from @metamask/messenger.
    • Update KeyringInternalSnapClientMessenger and SnapKeyringMessenger type definitions to use Messenger.
    • Adjust event payload typing via ExtractEventPayload from @metamask/messenger.
  • Tests:
    • Refactor SnapKeyring.test.ts to construct Messenger with namespaces (MOCK_ANY_NAMESPACE) and delegate allowed actions.
  • Dependencies:
    • Add @metamask/messenger@^0.3.0; remove @metamask/base-controller from affected packages.
  • Changelogs:
    • Note breaking changes for @metamask/keyring-internal-snap-client and @metamask/eth-snap-keyring regarding the messenger migration.

Written by Cursor Bugbot for commit 74cd0f8. This will update automatically on new commits. Configure here.

@mikesposito mikesposito added the DO-NOT-MERGE PRs related to this issue should not be merged label Sep 29, 2025
@mikesposito
mikesposito marked this pull request as ready for review September 29, 2025 16:44
@mikesposito
mikesposito requested a review from a team as a code owner September 29, 2025 16:44
cursor[bot]

This comment was marked as outdated.

@mikesposito

Copy link
Copy Markdown
Member Author

@metamaskbot publish-previews

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​metamask/​messenger@​0.3.01001007687100

View full report

@github-actions

Copy link
Copy Markdown

Preview builds have been published. See these instructions (from the core monorepo) for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/account-api": "0.12.0-74cd0f8",
  "@metamask-previews/keyring-api": "21.1.0-74cd0f8",
  "@metamask-previews/eth-hd-keyring": "13.0.0-74cd0f8",
  "@metamask-previews/eth-ledger-bridge-keyring": "11.1.2-74cd0f8",
  "@metamask-previews/eth-qr-keyring": "1.1.0-74cd0f8",
  "@metamask-previews/eth-simple-keyring": "11.0.0-74cd0f8",
  "@metamask-previews/eth-trezor-keyring": "9.0.0-74cd0f8",
  "@metamask-previews/keyring-internal-api": "9.1.0-74cd0f8",
  "@metamask-previews/keyring-internal-snap-client": "7.2.0-74cd0f8",
  "@metamask-previews/eth-snap-keyring": "17.3.0-74cd0f8",
  "@metamask-previews/keyring-snap-client": "8.1.0-74cd0f8",
  "@metamask-previews/keyring-snap-sdk": "7.1.0-74cd0f8",
  "@metamask-previews/keyring-utils": "3.1.0-74cd0f8"
}

@cryptodev-2s cryptodev-2s left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikesposito mikesposito removed the DO-NOT-MERGE PRs related to this issue should not be merged label Oct 27, 2025
@mikesposito
mikesposito enabled auto-merge October 27, 2025 09:31
@mikesposito
mikesposito disabled auto-merge October 27, 2025 09:32
@mikesposito
mikesposito enabled auto-merge October 27, 2025 10:15
@mikesposito
mikesposito added this pull request to the merge queue Oct 27, 2025
Merged via the queue into main with commit 7bcf574 Oct 27, 2025
35 of 37 checks passed
@mikesposito
mikesposito deleted the mikesposito/messenger branch October 27, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace RestrictedMessenger with delegated Messenger

3 participants