feat: add QrKeyringV2 wrapper#411
Merged
Merged
Conversation
mathieuartu
changed the title
QrKeyringV2 wrapperQrKeyringV2 wrapper
mathieuartu
changed the title
QrKeyringV2 wrapperQrKeyringV2 wrapper
mathieuartu
changed the title
QrKeyringV2 wrapperQrKeyringV2 wrapper
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
ccharly
reviewed
Dec 11, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
gantunesr
previously approved these changes
Jan 26, 2026
ccharly
reviewed
Jan 27, 2026
ccharly
reviewed
Jan 27, 2026
ccharly
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: https://consensyssoftware.atlassian.net/browse/MUL-1320
Examples
Note
Adds a new
QrKeyringV2adapter that wraps the legacyQrKeyringto expose accounts via the unifiedKeyringV2API with dynamic capabilities based on device mode.bip44:derive-index) and Account mode (customaddress selection), with entropy source validation and locking; supportsgetAccounts,createAccounts,deleteAccount,serialize/deserializeQrKeyringwithgetPathFromAddressandgetModehelpers; exportsQrKeyringV2and related types viaindex.ts@metamask/keyring-apiand@metamask/account-api; README dependency graph adjusted; adds comprehensive unit testsWritten by Cursor Bugbot for commit 685acf4. This will update automatically on new commits. Configure here.