feat!: remove KeyringVersion + simplify KeyringRequestWithoutOrigin logic#423
Merged
Conversation
KeyringInternalFeature{,s} support
hmalik88
previously approved these changes
Jan 13, 2026
KeyringInternalFeature{,s} supportKeyringVersion to KeyringInternalFeature{,s}
gantunesr
previously approved these changes
Jan 13, 2026
KeyringVersion to KeyringInternalFeature{,s}KeyringVersion + simplify Snap platform conditional logic
KeyringVersion + simplify Snap platform conditional logicKeyringVersion + simplify legacy KeyringRequest logic
gantunesr
previously approved these changes
Jan 14, 2026
KeyringVersion + simplify legacy KeyringRequest logicKeyringVersion + simplify KeyringRequestWithoutOrigin logic
gantunesr
reviewed
Jan 15, 2026
gantunesr
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
KeyringVersionsupport with a simpler solution, introducing a newKeyringRequestWithoutOriginwhich is more explicit and not really tied to any "keyring versions" (as we plan to re-use versioning with the introduction of the unified keyring API)This will allow to re-use a proper versioning of the keyring with the introduction of keyring capabilities.
Note
Simplifies compatibility by removing version gating and using an explicit request shape for legacy Snaps.
KeyringVersionand related helpers; deleteversions.tsand associated tests; dropexport * from './versions'KeyringRequestWithoutOriginstructs andtoKeyringRequestWithoutOrigin; update compatibility exports and testssubmitRequestV1tosubmitRequestWithoutOriginin the internal snap client and testsSnapKeyring, replace keyring-version branching with a platform check usingPLATFORM_VERSION_FOR_KEYRING_REQUEST_WITH_ORIGIN; callsubmitRequestwhen origin is supported, elsesubmitRequestWithoutOriginWritten by Cursor Bugbot for commit 5529979. This will update automatically on new commits. Configure here.