Skip to content

feat!: remove KeyringVersion + simplify KeyringRequestWithoutOrigin logic#423

Merged
ccharly merged 16 commits into
mainfrom
feat/add-keyring-internal-feature-support
Jan 15, 2026
Merged

feat!: remove KeyringVersion + simplify KeyringRequestWithoutOrigin logic#423
ccharly merged 16 commits into
mainfrom
feat/add-keyring-internal-feature-support

Conversation

@ccharly

@ccharly ccharly commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

Replace KeyringVersion support with a simpler solution, introducing a new KeyringRequestWithoutOrigin which is more explicit and not really tied to any "keyring versions" (as we plan to re-use versioning with the introduction of the unified keyring API)

This will allow to re-use a proper versioning of the keyring with the introduction of keyring capabilities.


Note

Simplifies compatibility by removing version gating and using an explicit request shape for legacy Snaps.

  • Remove KeyringVersion and related helpers; delete versions.ts and associated tests; drop export * from './versions'
  • Add KeyringRequestWithoutOrigin structs and toKeyringRequestWithoutOrigin; update compatibility exports and tests
  • Rename submitRequestV1 to submitRequestWithoutOrigin in the internal snap client and tests
  • In SnapKeyring, replace keyring-version branching with a platform check using PLATFORM_VERSION_FOR_KEYRING_REQUEST_WITH_ORIGIN; call submitRequest when origin is supported, else submitRequestWithoutOrigin

Written by Cursor Bugbot for commit 5529979. This will update automatically on new commits. Configure here.

@ccharly ccharly requested a review from a team as a code owner January 12, 2026 13:40
@ccharly ccharly changed the title feat: add KeyringInternalFeature{,s} support feat: add KeyringInternalFeature{,s} support Jan 12, 2026
hmalik88
hmalik88 previously approved these changes Jan 13, 2026
@ccharly ccharly changed the title feat: add KeyringInternalFeature{,s} support feat!: rename KeyringVersion to KeyringInternalFeature{,s} Jan 13, 2026
gantunesr
gantunesr previously approved these changes Jan 13, 2026
@ccharly ccharly changed the title feat!: rename KeyringVersion to KeyringInternalFeature{,s} feat!: remove KeyringVersion + simplify Snap platform conditional logic Jan 14, 2026
@ccharly ccharly changed the title feat!: remove KeyringVersion + simplify Snap platform conditional logic feat!: remove KeyringVersion + simplify legacy KeyringRequest logic Jan 14, 2026
gantunesr
gantunesr previously approved these changes Jan 14, 2026
@ccharly ccharly changed the title feat!: remove KeyringVersion + simplify legacy KeyringRequest logic feat!: remove KeyringVersion + simplify KeyringRequestWithoutOrigin logic Jan 15, 2026
Comment thread packages/keyring-snap-bridge/src/platform-versions.ts
@ccharly ccharly enabled auto-merge January 15, 2026 12:40
@ccharly ccharly added this pull request to the merge queue Jan 15, 2026
Merged via the queue into main with commit c0c3613 Jan 15, 2026
37 checks passed
@ccharly ccharly deleted the feat/add-keyring-internal-feature-support branch January 15, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants