fix: silent @typescript-eslint/no-redundant-type-constituents + fix local linting issues#437
Merged
Merged
Conversation
@typescript-eslint/no-redundant-type-constituents directives (#407)"@typescript-eslint/no-redundant-type-constituents directives (#407)
313fe0c to
4fe5bfb
Compare
@typescript-eslint/no-redundant-type-constituents directives (#407)@typescript-eslint/no-redundant-type-constituents directives (#407)
@typescript-eslint/no-redundant-type-constituents directives (#407)@typescript-eslint/no-redundant-type-constituents + fix local linting issues
gantunesr
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially reverting this PR:
@typescript-eslint/no-redundant-type-constituentsdirectives #407It turns out, the CI was happy with those changes, but it was giving us some other lint issues locally.
Still unsure what causes that (since it works fine on the CI). That seems to be a false-positive, and since this directive is not a "strong requirement" for increased type-safety, it's ok to disable it IMO.
Note
Streamlines linting and removes prior workarounds.
tsCommonRulesin.eslintrc.jsto disable@typescript-eslint/no-redundant-type-constituentsand applies it across multiple package overrides@metamask/*path entries fromjest.config.packages.jsandtsconfig.packages.jsonused as a workaroundpackages/keyring-internal-api/src/types.tsWritten by Cursor Bugbot for commit 056615a. This will update automatically on new commits. Configure here.