Skip to content

fix: silent @typescript-eslint/no-redundant-type-constituents + fix local linting issues#437

Merged
ccharly merged 8 commits into
mainfrom
revert/eslint-redundant-type-constituents
Jan 16, 2026
Merged

fix: silent @typescript-eslint/no-redundant-type-constituents + fix local linting issues#437
ccharly merged 8 commits into
mainfrom
revert/eslint-redundant-type-constituents

Conversation

@ccharly

@ccharly ccharly commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

Partially reverting this PR:

It turns out, the CI was happy with those changes, but it was giving us some other lint issues locally.

Still unsure what causes that (since it works fine on the CI). That seems to be a false-positive, and since this directive is not a "strong requirement" for increased type-safety, it's ok to disable it IMO.


Note

Streamlines linting and removes prior workarounds.

  • Introduces tsCommonRules in .eslintrc.js to disable @typescript-eslint/no-redundant-type-constituents and applies it across multiple package overrides
  • Removes extra @metamask/* path entries from jest.config.packages.js and tsconfig.packages.json used as a workaround
  • Adds a scoped ESLint disable for duplicate type constituents in packages/keyring-internal-api/src/types.ts
  • Refactors small test helpers in Ledger/Trezor keyring tests to use safer array access patterns

Written by Cursor Bugbot for commit 056615a. This will update automatically on new commits. Configure here.

@ccharly ccharly requested a review from a team as a code owner January 15, 2026 14:36
@ccharly ccharly changed the title Revert "fix: remove @typescript-eslint/no-redundant-type-constituents directives (#407)" revert: fix: remove @typescript-eslint/no-redundant-type-constituents directives (#407) Jan 15, 2026
@ccharly ccharly force-pushed the revert/eslint-redundant-type-constituents branch from 313fe0c to 4fe5bfb Compare January 16, 2026 13:04
@ccharly ccharly changed the title revert: fix: remove @typescript-eslint/no-redundant-type-constituents directives (#407) fix: remove @typescript-eslint/no-redundant-type-constituents directives (#407) Jan 16, 2026
@ccharly ccharly changed the title fix: remove @typescript-eslint/no-redundant-type-constituents directives (#407) fix: silent @typescript-eslint/no-redundant-type-constituents + fix local linting issues Jan 16, 2026
@ccharly ccharly added this pull request to the merge queue Jan 16, 2026
Merged via the queue into main with commit 74d38a1 Jan 16, 2026
40 checks passed
@ccharly ccharly deleted the revert/eslint-redundant-type-constituents branch January 16, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants