Skip to content

feat: add KeyringVersion + KeyringCapabilites.versions#439

Closed
ccharly wants to merge 2 commits into
mainfrom
feat/keyring-capabilities-versions
Closed

feat: add KeyringVersion + KeyringCapabilites.versions#439
ccharly wants to merge 2 commits into
mainfrom
feat/keyring-capabilities-versions

Conversation

@ccharly

@ccharly ccharly commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

Adding a new versions field in the capabilities.

This way, we will know what keyring API versions is supported and potentially adapt the requests we're sending to that keyring.


Note

Introduces explicit keyring API versioning and updates implementations to declare support.

  • Add KeyringVersion enum (V1, V2) and require non-empty versions in KeyringCapabilities (keyring-capabilities.ts)
  • Update Ethereum keyring wrappers (hd-keyring-v2.ts, ledger-keyring-v2.ts, simple-keyring-v2.ts, trezor-keyring-v2.ts) to include versions: [KeyringVersion.V2]
  • Adjust tests to provide versions in capabilities (keyring-wrapper.test.ts)
  • Document changes in CHANGELOG.md

Written by Cursor Bugbot for commit 1cacda0. This will update automatically on new commits. Configure here.

@ccharly ccharly requested a review from a team as a code owner January 15, 2026 15:38
@ccharly

ccharly commented Jan 28, 2026

Copy link
Copy Markdown
Contributor Author

Closing this one as we might want to couple the new V2 change with a new Snap platform version. The long-term plan would be to incorporate the keyring API support within the platform itself, allowing us to benefit from a global versioning rather than a sub-version only for the keyring part.

@ccharly ccharly closed this Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants