Skip to content

fix: fix prepare-preview-builds.ts #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ccharly merged 1 commit into from
Jan 21, 2026
Merged

fix: fix prepare-preview-builds.ts #444

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions scripts/prepare-preview-builds.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,8 @@ async function updateWorkspacePackagesWithPreviewInfo(
const peerDepKey = 'peerDependencies';
if (peerDepKey in pkgJson.content) {
const depKey = 'dependencies';
const deps = pkgJson.content[depKey] as DependenciesRecord;
const peerDeps = pkgJson.content[peerDepKey] as DependenciesRecord;
const deps: DependenciesRecord = pkgJson.content[depKey] ?? {};
const peerDeps: DependenciesRecord = pkgJson.content[peerDepKey] ?? {};

for (const { name, version } of previewPkgs) {
// Only consider dependenc that refers to a local workspace package
Expand All @@ -173,7 +173,7 @@ async function updateWorkspacePackagesWithPreviewInfo(
// of that package instead, and `yarn` will resolve this using the global resolutions
// (see `updateWorkspaceResolutions`)
for (const depKey of ['dependencies', 'devDependencies']) {
const deps = pkgJson.content[depKey] as DependenciesRecord;
const deps: DependenciesRecord = pkgJson.content[depKey] ?? {};

@cursor cursor Bot Jan 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty dependency objects added to package.json unnecessarily

Medium Severity

When pkgJson.content[depKey] is undefined, the fallback ?? {} creates an empty object. The code then unconditionally calls pkgJson.update({ [depKey]: deps }) even when no modifications were made. This adds empty dependencies: {} or devDependencies: {} to package.json files that didn't originally have these fields, polluting the manifests of packages like account-api that don't depend on other workspace packages.

Additional Locations (1)

Fix in Cursor Fix in Web

@ccharly ccharly Jan 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's ok. We use preview builds for dev purposes. As long as we're not overwriting any deps, we're good.


for (const { name, version } of previewPkgs) {
// Only consider dependenc that refers to a local workspace package
Expand Down
Loading