Skip to content

feat: convert capabilities to getter for subclass overrides#447

Merged
mathieuartu merged 4 commits into
mainfrom
feat/capabilities-getter
Jan 27, 2026
Merged

feat: convert capabilities to getter for subclass overrides#447
mathieuartu merged 4 commits into
mainfrom
feat/capabilities-getter

Conversation

@mathieuartu

@mathieuartu mathieuartu commented Jan 27, 2026

Copy link
Copy Markdown
Contributor

Examples


Note

Makes keyring capabilities dynamically overridable.

  • Change KeyringWrapper.capabilities from a readonly property to a getter, enabling subclasses to compute capabilities at runtime
  • Update QrKeyringV2 to override capabilities and return mode-specific capabilities (ACCOUNT vs HD) instead of redefining the property via Object.defineProperty
  • Update changelogs for keyring-api and keyring-eth-qr to document the change

Written by Cursor Bugbot for commit 32aa0bd. This will update automatically on new commits. Configure here.

@mathieuartu mathieuartu requested a review from a team as a code owner January 27, 2026 14:52
@mathieuartu mathieuartu self-assigned this Jan 27, 2026
Comment thread packages/keyring-eth-qr/CHANGELOG.md Outdated
Comment thread packages/keyring-api/src/api/v2/wrapper/keyring-wrapper.ts
@mathieuartu mathieuartu added this pull request to the merge queue Jan 27, 2026
Merged via the queue into main with commit 5d1a25b Jan 27, 2026
37 checks passed
@mathieuartu mathieuartu deleted the feat/capabilities-getter branch January 27, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants