-
-
Notifications
You must be signed in to change notification settings - Fork 225
**BREAKING** Add PermissionTree
class & introduce children
to Permission specifications
#1513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hmalik88
wants to merge
15
commits into
main
Choose a base branch
from
hm/add-permission-groups
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
3fc69dc
added PermissionTree class
hmalik88 1cca663
updated PermissionTree and added test
hmalik88 9f97a0a
updated PermissionTree & tests, added jsdoc comments
hmalik88 4866d6c
Merge branch 'main' into hm/add-permission-groups
hmalik88 3cbf32d
fix linting errors
hmalik88 c849eae
add spacing
hmalik88 05b5734
Merge branch 'main' into hm/add-permission-groups
hmalik88 55c27a8
added tests for permission groups integration
hmalik88 635f23b
Merge branch 'main' into hm/add-permission-groups
hmalik88 d888e56
lint fix
hmalik88 332c8ac
another fix
hmalik88 34e8b0d
update test names
hmalik88 34620f2
move side effects to grant permissions and update tests
hmalik88 53da778
Merge branch 'main' into hm/add-permission-groups
hmalik88 b6bfbb0
lint fixes
hmalik88 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we enforce that only a special type of permission can have children?
I am thinking it might be useful to define a
PermissionGroup
similarly to how we have endowments and RPC methods currently and only allow permissions of type "permission group" to actually function as a group.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-doing this PR based on a convo w/ @rekmarks to keep a concept of groups as well, minus the need for an extraneous permission in state.