Skip to content

feat: Implement display nft media #1618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

feat: Implement display nft media #1618

wants to merge 13 commits into from

Conversation

tommasini
Copy link
Contributor

References

relates to: https://github.com/MetaMask/mobile-planning/issues/1166

@metamask/preferences-controller

  • : changed name of openSeaEnabled variable to displayNftMedia

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@tommasini tommasini requested a review from a team as a code owner August 21, 2023 15:40
@tommasini tommasini changed the title feat: implement nft media feat: Change display nft media Aug 21, 2023
@tommasini tommasini changed the title feat: Change display nft media feat: Implement display nft media Aug 21, 2023
@tommasini tommasini requested a review from a team as a code owner October 20, 2023 15:40
@tommasini
Copy link
Contributor Author

Converting this to a draft, need to revert the two last commit, merge main again and solve the conflicts

@tommasini tommasini marked this pull request as draft October 20, 2023 18:38
@tommasini
Copy link
Contributor Author

closed this PR in order to open this one
This was done due to a mistake on merging conflicts and revering commits

@tommasini tommasini closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant