feat: add lastUpdatedAt to NetworkConfiguration #4652
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prithpal-Sooriya
added
the
team-notifications
Prithpal-Sooriya
commented
Sep 3, 2024
Comment on lines
+144
to
+149
| jest | ||
| .spyOn( | ||
| LastUpdatedAtNetworkConfigurationModule, | ||
| 'lastUpdatedNetworkConfiguration', | ||
| ) | ||
| .mockImplementation((n) => n); |
There was a problem hiding this comment.
I need some thoughts on this.
The addition of the lastUpdatedAt field breaks many tests, especially when adding or updating a network. This is fine, however it also breaks tests that are marked as "if nothing is being changes > makes no updates to state".
We may need to rethink where we set the lastUpdatedAt field.
this allows tracking of when the network configuration was updated, which is used to enable accurate network syncing
Prithpal-Sooriya
force-pushed
the
NOTIFY-1031/add-network-sync-fields
branch
from
8d92989
to
7b57cb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This allows tracking of when the network configuration was updated, which is used to enable accurate network syncing
References
Changelog
@metamask/network-controllerlastUpdatedAtto theNetworkConfigurationstate. Used for performing network syncing.lastUpdatedAtwhen a network is added or updated.Checklist