feat: enhance account name generation for multichain accounts #5382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrykLucka
force-pushed
the
multi-chain-account-name-generation
branch
from
ab5de2b to
95a6811
Compare
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
PatrykLucka
force-pushed
the
multi-chain-account-name-generation
branch
from
95a6811 to
def92ff
Compare
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
PatrykLucka
force-pushed
the
multi-chain-account-name-generation
branch
from
def92ff to
9882740
Compare
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
PatrykLucka
force-pushed
the
multi-chain-account-name-generation
branch
from
509bc9d to
5547897
Compare
PatrykLucka
force-pushed
the
multi-chain-account-name-generation
branch
from
c348f27 to
edbe12d
Compare
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR updates the
getNextAvailableAccountNamefunction in the AccountsController to change the way new acocunts is generated, allowing to support Solana and Bitcoin accounts names generation. It makesgetNextAvailableAccountNamefunction parameter optional with a default value of KeyringTypes.hd.New Account Naming Rules:
Calculate the Number of Accounts:
Accounts are named using the format: prefix + "Account" + Account number.
The Account number is determined by summing the following:
All eth-hd-keyring accounts.
All simple keyring accounts.
All snap accounts that have an account.options.entropySource referring to an eth-hd-keyring.
Add 1 to the total sum.
Check the Highest Existing Account Number:
Identify the highest Account number currently in the state that starts with Account, Solana Account, or Bitcoin Account.
Determine the Higher Number:
References
Jira ricket
Changelog
@metamask/accounts-controllergetNextAvailableAccountNameparameter single, optional property with default KeyringTypes.hdgetNextAvailableAccountNamefollows different logic of name generationChecklist