chore: explicitly pass networkClientId for nftController #5622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sahar-fehri
commented
Apr 11, 2025
| this.messagingSystem.subscribe( | ||
| 'NetworkController:networkDidChange', | ||
| this.#onNetworkControllerNetworkDidChange.bind(this), | ||
| ); |
There was a problem hiding this comment.
This subscription is removed because the purpose of onNetworkControllerNetworkDidChange was to populate this.#chainId which has been removed
sahar-fehri
commented
Apr 11, 2025
| selectedNetworkClientId, | ||
| ); | ||
| this.#chainId = chainId; | ||
| } |
There was a problem hiding this comment.
Removed this because subscription was also removed
sahar-fehri
commented
Apr 11, 2025
| return chainId; | ||
| } | ||
| return this.#chainId; | ||
| } |
There was a problem hiding this comment.
This has been removed and we are making a call to NetworkController:getNetworkClientById when needed since we no longer fallback to this.#chainId
sahar-fehri
commented
Apr 11, 2025
| // TODO: revisit this with Solana support and instead of passing chainId, make sure chainId is read from nftMetadata | ||
| const chainIdToAddTo = | ||
| chainId || this.#getCorrectChainId({ networkClientId }); | ||
|
|
There was a problem hiding this comment.
Removed this in favor of the mandatory networkClientId;
This will be called from nftDetectionController to add NFTs in which case we will take the chainId from the NFT and find the networkClientId. Or directly from clients, in which case they need to provide the networkClientId.
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
TODO: Changelog |
mcmire
reviewed
Apr 18, 2025
salimtb
force-pushed
the
feat/make-chainId-mandatory-in-nft-controller
branch
2 times, most recently
from
0d5cebc to
476edcf
Compare
salimtb
force-pushed
the
feat/make-chainId-mandatory-in-nft-controller
branch
from
476edcf to
42bb475
Compare
|
@metamaskbot publish-preview |
1 similar comment
|
@metamaskbot publish-preview |
salimtb
previously approved these changes
Apr 28, 2025
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
mcmire
reviewed
May 28, 2025
7 tasks
mcmire
reviewed
May 30, 2025
Prithpal-Sooriya
approved these changes
May 30, 2025
github-merge-queue bot
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Jun 3, 2025
## **Description** This PR integrates the changes from this core PR MetaMask/core#5622 Making networkClientId no longer optional for `nftController` and `nftDetectionController` functions. Users should not experience any changes related to NFT flows. [](https://codespaces.new/MetaMask/metamask-extension/pull/31917?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** Test autodetection 1. Import a new account that you know has NFTs on linea or Ethereum mainnet 2. Go to NFT tab. 3. You should see a loader then your NFTs will appear correctly 4. Switch between popular networks and current network and it should filter your NFTs correctly Test import/remove NFT 1. Go to NFT tab 2. Click on any NFT 3. Click on options and click remove NFT 4. NFT should be removed successfully 5. Re-import the NFT (whether on the NFT network or another network) 6. NFT should be imported successfully ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: salimtb <[email protected]> Co-authored-by: MetaMask Bot <[email protected]>
](https://codespaces.new/MetaMask/metamask-extension/pull/31917?quickstart=1){kind=link}
github-merge-queue bot
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Jun 3, 2025
## **Description** This PR integrates the changes from this core PR MetaMask/core#5622 Making networkClientId no longer optional for `nftController` and `nftDetectionController` functions. Users should not experience any changes related to NFT flows. [](https://codespaces.new/MetaMask/metamask-extension/pull/31917?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** Test autodetection 1. Import a new account that you know has NFTs on linea or Ethereum mainnet 2. Go to NFT tab. 3. You should see a loader then your NFTs will appear correctly 4. Switch between popular networks and current network and it should filter your NFTs correctly Test import/remove NFT 1. Go to NFT tab 2. Click on any NFT 3. Click on options and click remove NFT 4. NFT should be removed successfully 5. Re-import the NFT (whether on the NFT network or another network) 6. NFT should be imported successfully ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: salimtb <[email protected]> Co-authored-by: MetaMask Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR is part of a larger effort to remove the global network selector.
On this PR:
UI integration:
References
NFTController: Remove Private Property#chainIdand the fallback on current selected network #5581Changelog
@metamask/assets-controllersNftControllerandNftDetectionControllerto eliminate the dependency on the current chain. All functions that previously accepted networkClientId as an optional parameter now require it as a mandatory parameterChecklist