Skip to content

feat: rename profile sync to backup and sync #5686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 7, 2025
Merged

feat: rename profile sync to backup and sync #5686

merged 5 commits into from
May 7, 2025
+46 −66

Conversation

mathieuartu
Copy link
Contributor

@mathieuartu mathieuartu commented Apr 22, 2025 •
edited
Loading

Explanation

This PR updates all profile syncing references to backup and sync.
This involves state properties name changes, so the clients will need to write migrations when bumping.

This is a breaking change.

Instructions for client migration are basically the test drive PRs below:

References

Related to: https://consensyssoftware.atlassian.net/browse/IDENTITY-88

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@mathieuartu mathieuartu added the team-identity Identity Team changes. https://github.com/orgs/MetaMask/teams/identity label Apr 22, 2025
@mathieuartu mathieuartu self-assigned this Apr 22, 2025
@mathieuartu
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "27.0.0-preview-dd19f50",
  "@metamask-previews/address-book-controller": "6.0.3-preview-dd19f50",
  "@metamask-previews/announcement-controller": "7.0.3-preview-dd19f50",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-dd19f50",
  "@metamask-previews/approval-controller": "7.1.3-preview-dd19f50",
  "@metamask-previews/assets-controllers": "58.0.0-preview-dd19f50",
  "@metamask-previews/base-controller": "8.0.0-preview-dd19f50",
  "@metamask-previews/bridge-controller": "16.0.0-preview-dd19f50",
  "@metamask-previews/bridge-status-controller": "13.1.0-preview-dd19f50",
  "@metamask-previews/build-utils": "3.0.3-preview-dd19f50",
  "@metamask-previews/chain-agnostic-permission": "0.4.0-preview-dd19f50",
  "@metamask-previews/composable-controller": "11.0.0-preview-dd19f50",
  "@metamask-previews/controller-utils": "11.7.0-preview-dd19f50",
  "@metamask-previews/delegation-controller": "0.1.0-preview-dd19f50",
  "@metamask-previews/earn-controller": "0.12.0-preview-dd19f50",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-dd19f50",
  "@metamask-previews/ens-controller": "16.0.0-preview-dd19f50",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-dd19f50",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-dd19f50",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-dd19f50",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-dd19f50",
  "@metamask-previews/keyring-controller": "21.0.3-preview-dd19f50",
  "@metamask-previews/logging-controller": "6.0.4-preview-dd19f50",
  "@metamask-previews/message-manager": "12.0.1-preview-dd19f50",
  "@metamask-previews/multichain": "4.0.0-preview-dd19f50",
  "@metamask-previews/multichain-api-middleware": "0.2.0-preview-dd19f50",
  "@metamask-previews/multichain-network-controller": "0.5.1-preview-dd19f50",
  "@metamask-previews/multichain-transactions-controller": "0.9.0-preview-dd19f50",
  "@metamask-previews/name-controller": "8.0.3-preview-dd19f50",
  "@metamask-previews/network-controller": "23.2.0-preview-dd19f50",
  "@metamask-previews/notification-services-controller": "6.0.0-preview-dd19f50",
  "@metamask-previews/permission-controller": "11.0.6-preview-dd19f50",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-dd19f50",
  "@metamask-previews/phishing-controller": "12.4.1-preview-dd19f50",
  "@metamask-previews/polling-controller": "13.0.0-preview-dd19f50",
  "@metamask-previews/preferences-controller": "17.0.0-preview-dd19f50",
  "@metamask-previews/profile-sync-controller": "12.0.0-preview-dd19f50",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-dd19f50",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-dd19f50",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-dd19f50",
  "@metamask-previews/sample-controllers": "0.1.0-preview-dd19f50",
  "@metamask-previews/selected-network-controller": "22.0.0-preview-dd19f50",
  "@metamask-previews/signature-controller": "27.1.0-preview-dd19f50",
  "@metamask-previews/token-search-discovery-controller": "3.1.0-preview-dd19f50",
  "@metamask-previews/transaction-controller": "54.1.0-preview-dd19f50",
  "@metamask-previews/user-operation-controller": "33.0.0-preview-dd19f50"
}

@mathieuartu mathieuartu mentioned this pull request Apr 23, 2025
Merged
7 tasks
@mathieuartu mathieuartu mentioned this pull request Apr 30, 2025
Merged
7 tasks
@mathieuartu
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "28.0.0-preview-36565d85",
  "@metamask-previews/address-book-controller": "6.0.3-preview-36565d85",
  "@metamask-previews/announcement-controller": "7.0.3-preview-36565d85",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-36565d85",
  "@metamask-previews/approval-controller": "7.1.3-preview-36565d85",
  "@metamask-previews/assets-controllers": "61.0.0-preview-36565d85",
  "@metamask-previews/base-controller": "8.0.1-preview-36565d85",
  "@metamask-previews/bridge-controller": "21.0.0-preview-36565d85",
  "@metamask-previews/bridge-status-controller": "18.0.0-preview-36565d85",
  "@metamask-previews/build-utils": "3.0.3-preview-36565d85",
  "@metamask-previews/chain-agnostic-permission": "0.6.0-preview-36565d85",
  "@metamask-previews/composable-controller": "11.0.0-preview-36565d85",
  "@metamask-previews/controller-utils": "11.7.0-preview-36565d85",
  "@metamask-previews/delegation-controller": "0.2.0-preview-36565d85",
  "@metamask-previews/earn-controller": "0.13.0-preview-36565d85",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-36565d85",
  "@metamask-previews/ens-controller": "16.0.0-preview-36565d85",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-36565d85",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-36565d85",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-36565d85",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-36565d85",
  "@metamask-previews/keyring-controller": "21.0.6-preview-36565d85",
  "@metamask-previews/logging-controller": "6.0.4-preview-36565d85",
  "@metamask-previews/message-manager": "12.0.1-preview-36565d85",
  "@metamask-previews/multichain": "4.0.0-preview-36565d85",
  "@metamask-previews/multichain-api-middleware": "0.2.0-preview-36565d85",
  "@metamask-previews/multichain-network-controller": "0.6.0-preview-36565d85",
  "@metamask-previews/multichain-transactions-controller": "0.10.0-preview-36565d85",
  "@metamask-previews/name-controller": "8.0.3-preview-36565d85",
  "@metamask-previews/network-controller": "23.3.0-preview-36565d85",
  "@metamask-previews/notification-services-controller": "7.0.0-preview-36565d85",
  "@metamask-previews/permission-controller": "11.0.6-preview-36565d85",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-36565d85",
  "@metamask-previews/phishing-controller": "12.5.0-preview-36565d85",
  "@metamask-previews/polling-controller": "13.0.0-preview-36565d85",
  "@metamask-previews/preferences-controller": "17.0.0-preview-36565d85",
  "@metamask-previews/profile-sync-controller": "13.0.0-preview-36565d85",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-36565d85",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-36565d85",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-36565d85",
  "@metamask-previews/sample-controllers": "0.1.0-preview-36565d85",
  "@metamask-previews/selected-network-controller": "22.0.0-preview-36565d85",
  "@metamask-previews/signature-controller": "28.0.0-preview-36565d85",
  "@metamask-previews/token-search-discovery-controller": "3.1.0-preview-36565d85",
  "@metamask-previews/transaction-controller": "55.0.0-preview-36565d85",
  "@metamask-previews/user-operation-controller": "34.0.0-preview-36565d85"
}

@mathieuartu mathieuartu mentioned this pull request May 7, 2025
Draft
7 tasks
@mathieuartu
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. 
{
  "@metamask-previews/accounts-controller": "28.0.0-preview-be835479",
  "@metamask-previews/address-book-controller": "6.0.3-preview-be835479",
  "@metamask-previews/announcement-controller": "7.0.3-preview-be835479",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-be835479",
  "@metamask-previews/approval-controller": "7.1.3-preview-be835479",
  "@metamask-previews/assets-controllers": "61.0.0-preview-be835479",
  "@metamask-previews/base-controller": "8.0.1-preview-be835479",
  "@metamask-previews/bridge-controller": "21.0.0-preview-be835479",
  "@metamask-previews/bridge-status-controller": "18.0.0-preview-be835479",
  "@metamask-previews/build-utils": "3.0.3-preview-be835479",
  "@metamask-previews/chain-agnostic-permission": "0.6.0-preview-be835479",
  "@metamask-previews/composable-controller": "11.0.0-preview-be835479",
  "@metamask-previews/controller-utils": "11.7.0-preview-be835479",
  "@metamask-previews/delegation-controller": "0.2.0-preview-be835479",
  "@metamask-previews/earn-controller": "0.13.0-preview-be835479",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-be835479",
  "@metamask-previews/ens-controller": "16.0.0-preview-be835479",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-be835479",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-be835479",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-be835479",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-be835479",
  "@metamask-previews/keyring-controller": "21.0.6-preview-be835479",
  "@metamask-previews/logging-controller": "6.0.4-preview-be835479",
  "@metamask-previews/message-manager": "12.0.1-preview-be835479",
  "@metamask-previews/multichain": "4.0.0-preview-be835479",
  "@metamask-previews/multichain-api-middleware": "0.2.0-preview-be835479",
  "@metamask-previews/multichain-network-controller": "0.6.0-preview-be835479",
  "@metamask-previews/multichain-transactions-controller": "0.10.0-preview-be835479",
  "@metamask-previews/name-controller": "8.0.3-preview-be835479",
  "@metamask-previews/network-controller": "23.3.0-preview-be835479",
  "@metamask-previews/notification-services-controller": "7.0.0-preview-be835479",
  "@metamask-previews/permission-controller": "11.0.6-preview-be835479",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-be835479",
  "@metamask-previews/phishing-controller": "12.5.0-preview-be835479",
  "@metamask-previews/polling-controller": "13.0.0-preview-be835479",
  "@metamask-previews/preferences-controller": "17.0.0-preview-be835479",
  "@metamask-previews/profile-sync-controller": "13.0.0-preview-be835479",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-be835479",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-be835479",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-be835479",
  "@metamask-previews/sample-controllers": "0.1.0-preview-be835479",
  "@metamask-previews/selected-network-controller": "22.0.0-preview-be835479",
  "@metamask-previews/signature-controller": "28.0.0-preview-be835479",
  "@metamask-previews/token-search-discovery-controller": "3.1.0-preview-be835479",
  "@metamask-previews/transaction-controller": "55.0.0-preview-be835479",
  "@metamask-previews/user-operation-controller": "34.0.0-preview-be835479"
}

@mathieuartu mathieuartu force-pushed the feat/replace-profile-sync-backup-and-sync branch from be83547 to 6f7c54c Compare May 7, 2025 14:19
@mathieuartu mathieuartu mentioned this pull request May 7, 2025
Draft
7 tasks
@mathieuartu mathieuartu marked this pull request as ready for review May 7, 2025 15:43
@mathieuartu mathieuartu requested review from a team as code owners May 7, 2025 15:43
@mathieuartu mathieuartu enabled auto-merge (squash) May 7, 2025 17:41
@mathieuartu mathieuartu merged commit 4c2c591 into main May 7, 2025
202 checks passed
@mathieuartu mathieuartu deleted the feat/replace-profile-sync-backup-and-sync branch May 7, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiobozzo fabiobozzo fabiobozzo approved these changes

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

Assignees

@mathieuartu mathieuartu

Labels
no-changelog team-identity Identity Team changes. https://github.com/orgs/MetaMask/teams/identity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathieuartu @fabiobozzo @Prithpal-Sooriya